Good length. I ordered these along with the knee length denim shorts thinking these would be the ones I was unhappy with. I actually like them due to them not being as short as I was worried about and will be keeping them. I’m either a size 12 or 14, depending. ordered the 14 but probably could have done with the 12. The fit is otherwise good.